Skip to content

Conversation

@Nielsbishere
Copy link
Contributor

This fix changes the looks of the radio buttons (like vurtun/nuklear#653 zhouxs1023's Modify the appearance for option and checkbox!).

With a few minor changes to make it clearer. And README has been changed accordingly and a more thorough example was added.

… for vertices (they check correctly now).

Paq.sh now automatically outputs to nuklear.h.
keharriso's Prevent clicking more than one (overlapping) button per frame.
However, this has a couple of other changes that should fix dropdowns from intefering as well.
- Sets click to 0 every start of frame
- Input was still down for that frame, so it triggered the next event
Now it waits for your button to go back up before resetting the clicked variable, so as long as your mouse is down, only one item is clicked.
…checkbox!

With README changes that show off more features and the updated style. Slightly modified.
Copy link
Member

@dumblob dumblob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump version and fix conflicts with other your PRs 😉. Then I'll merge. And thanks again for your effort!

Readme.md Outdated
/* init gui state */
struct nk_context ctx;
nk_init_fixed(&ctx, calloc(1, MAX_MEMORY), MAX_MEMORY, &font);
struct nk_context *ctx = (nk_context*) malloc(sizeof(nk_context));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: why on heap? It's a small struct and the less allocated memory you have to manage, the better (and more readable).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I'll fix this, it's because on my own project there's too much on the stack already.

@Nielsbishere
Copy link
Contributor Author

Updated.

@dumblob
Copy link
Member

dumblob commented Dec 9, 2019

Please bump version also in src/CHANGELOG (and regenerate nuklear.h).

Btw. why did you remove all the consts? They're quite useful IMHO. Or is it some residual after debugging/testing the lib?

@Nielsbishere
Copy link
Contributor Author

Will do, the consts are because of the merge with fix_click. The input struct can't be const, since clicking in the mouse rect will modify it (so you can't click through two objects and active both of them).

@Nielsbishere
Copy link
Contributor Author

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants